Skip to content

branch-4.1: [fix](fe) Preserve narrowing datetimev2 casts in simplify in predicate #63343#63421

Open
github-actions[bot] wants to merge 1 commit into
branch-4.1from
auto-pick-63343-branch-4.1
Open

branch-4.1: [fix](fe) Preserve narrowing datetimev2 casts in simplify in predicate #63343#63421
github-actions[bot] wants to merge 1 commit into
branch-4.1from
auto-pick-63343-branch-4.1

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Cherry-picked from #63343

#63343)

### What problem does this PR solve?
SimplifyInPredicate could incorrectly remove narrowing DATETIMEV2 casts
inside IN predicates.
For expressions such as `CAST(datetimev2(6) AS DATETIMEV2(3)) IN (...)`,
the rewrite could turn the predicate
into a direct comparison on the original DATETIMEV2(6) column, which is
not semantics-preserving because the cast
uses precision reduction and rounding. The rule also used a binary-based
microsecond alignment check instead of a
decimal scale check, which could incorrectly treat some literals as
losslessly convertible.

This change restricts the rewrite to non-narrowing DATETIMEV2 casts and
fixes the literal alignment check to use
decimal scale factors. It also adds FE unit tests and a regression case
for the reported DATETIMEV2 scenario.
@github-actions github-actions Bot requested a review from yiguolei as a code owner May 20, 2026 02:45
@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen
Copy link
Copy Markdown
Contributor

run buildall

@hello-stephen
Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 42.86% (3/7) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 5.80% (4/69) 🎉
Increment coverage report
Complete coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants